-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize patching to support vendoring #38
Generalize patching to support vendoring #38
Conversation
…ors to work on empty directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow - This is impressive. I'm a bit scared of the complexity here, but I doubt there is a much simpler way to achieve what we need.
I wonder if the following sequence of events make sense?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this and have only one minor suggestion to restrict the scope of patching the vendored file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, now that the patch is applied only to the affected Python/Dask versions. (I have not verified that this passes locally.)
rapids_dask_dependency/patches/dask/dataframe/__rdd_patch_accessor.py
Outdated
Show resolved
Hide resolved
…ssor.py Co-authored-by: Richard (Rick) Zamora <rzamora217@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is heroic work @vyasr - Thanks for saving the day!
\merge |
This PR was reverted via force push so that it can be merged via the bot instead (in #39). |
This PR makes a number of significant changes to the patching infrastructure:
patches
directory corresponding to a particular dask or distributed module.sys.modules
with the real modules and therefore the loader will never be used for loading a patched version of the submodule.dask.dataframe
import error for Python 3.11.9 dask/dask#11035.