Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] rapids_cpm_spdlog generate correct build config support #387

Closed
robertmaynard opened this issue Mar 10, 2023 · 3 comments
Closed

[FEA] rapids_cpm_spdlog generate correct build config support #387

robertmaynard opened this issue Mar 10, 2023 · 3 comments
Assignees
Labels
feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

Currently projects need to manually generate a build directory config module ( e.g. )

include(${rapids-cmake-dir}/cpm/spdlog.cmake)
  rapids_cpm_spdlog(FMT_OPTION "EXTERNAL_FMT_HO" INSTALL_EXPORT_SET rmm-exports)
  rapids_export_package(BUILD spdlog rmm-exports)

  if(spdlog_ADDED)
    rapids_export(
      BUILD spdlog
      EXPORT_SET spdlog
      GLOBAL_TARGETS spdlog spdlog_header_only
      NAMESPACE spdlog::)
    include("${rapids-cmake-dir}/export/find_package_root.cmake")
    rapids_export_find_package_root(BUILD spdlog [=[${CMAKE_CURRENT_LIST_DIR}]=] rmm-exports)
  endif()

Describe the solution you'd like

We should do this for projects in rapids_cpm_spdlog

@robertmaynard robertmaynard added feature request New feature or request 1 - On Deck To be worked on next labels Mar 10, 2023
@robertmaynard robertmaynard self-assigned this Mar 10, 2023
@robertmaynard robertmaynard added 2 - In Progress Currenty a work in progress and removed 1 - On Deck To be worked on next labels Apr 25, 2024
@jameslamb
Copy link
Member

Adding some links.

I think that instead of doing this for projects in rapids_cpm_spdlog(), we can soon just remove that manual exporting from projects' get_spdlog.cmake.

Assuming rapidsai/build-planning#56 is completed (see #592), across RAPIDS we'll be using spdlog>=1.13.0 , which contains @robertmaynard 's fix to its build exports to prevent the need for exactly this type of export management by projects that depend on spdlog: gabime/spdlog#2846.

@jameslamb
Copy link
Member

jameslamb commented Sep 19, 2024

AyodeAwe pushed a commit to rapidsai/cudf that referenced this issue Sep 23, 2024
## Description

Replaces #15603

Contributes to:

* rapidsai/build-planning#54
* rapidsai/build-planning#56
* rapidsai/rapids-cmake#387

Now that most of `conda-forge` has been updated to `fmt >=11.0.1,<12`
and `spdlog>=1.14.1,<1.15`
(rapidsai/build-planning#56 (comment)),
we're attempting to upgrade RAPIDS to similar versions of those
libraries.

This improves the likelihood that RAPIDS will be installable alongside
newer versions of its
dependencies and complementary packages on conda-forge.

## Notes for Reviewers

This PR is testing changes made in
rapidsai/rapids-cmake#689.
It shouldn't be merged until those `rapids-cmake` changes are merged and
any testing-specific details have been removed.
@jameslamb
Copy link
Member

I think this can be closed!

The now-extraneous rapids_export() calls were removed in the PRs linked in #387 (comment).

There are not any remaining across RAPIDS: https://github.com/search?q=org%3Arapidsai+%22NAMESPACE+spdlog%3A%3A%22+AND+NOT+is%3Aarchived&type=code

@jameslamb jameslamb removed the 2 - In Progress Currenty a work in progress label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants