Update rapids-cmake version for pyraft in update-version.sh #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
sevagh
approved these changes
Jul 22, 2022
robertmaynard
requested changes
Jul 22, 2022
There was a problem hiding this comment.
As we ae now up to 3 places using rapids-cmake we should switch over to the approach cudf is using where we have a single fetch_rapids that each project includes.
https://github.com/rapidsai/cudf/blob/branch-22.08/fetch_rapids.cmake
robertmaynard
requested changes
Jul 22, 2022
vyasr
force-pushed
the
fix/update_version_raft_rapids_cmake
branch
from
8fdada4
to
78e23ba
Compare
|
Whoops sorry about that. |
robertmaynard
approved these changes
Jul 22, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only pylibraft's copy was being updated, leading to an out-of-date branch of rapids-cmake being pulled for pyraft.