Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding conda packaging for libraft and pyraft #439

Merged
merged 109 commits into from
Jan 26, 2022
Merged

Adding conda packaging for libraft and pyraft #439

merged 109 commits into from
Jan 26, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jan 11, 2022

No description provided.

@trxcllnt
add option to build faiss shared libs
07644ec
@trxcllnt
add FAISS::FAISS to the list of global targets
f3e1f09
@trxcllnt
update cuco
e038644
@trxcllnt
create a faissTargets export-set
3fa9c94
@trxcllnt
Merge branch 'fix/build-shared-faiss' into fix/node-rapids-21.10
fc132ef
@trxcllnt
add faiss to raft-exports
85572d0
@trxcllnt
revert
b19a4b6
@trxcllnt
Merge branch 'fix/build-shared-faiss' into fix/node-rapids-21.10
6c74570
@trxcllnt
create a faiss-exports export-set
14785ff
@trxcllnt
mark faiss to be found as part of resolving raft-exports dependencies
25b62e6
@trxcllnt
create faiss-exports export set
76edf36
@trxcllnt
create faiss-exports export set
92851b3
@trxcllnt
export faiss::faiss target to build export set
8e266ef
@trxcllnt
Merge branch 'fix/node-rapids-21.10' into fix/build-shared-faiss
9d535fb
@trxcllnt
Merge branch 'branch-21.10' of github.com:rapidsai/raft into fix/buil…
7c990b1 
…d-shared-faiss
@trxcllnt
Merge branch 'branch-21.12' of github.com:rapidsai/raft into fix/buil…
3a20c64 
…d-shared-faiss
@trxcllnt
fix faiss GLOBAL_TARGETS
83e3aa6
@trxcllnt
update rapids-cmake version
2773edc
@trxcllnt
fix naming for generated Findfaiss.cmake module so we find conda-inst…
3ff1c4d 
…alled faiss
@trxcllnt
ensure faiss::faiss target is available in build and install export sets
cbb6f2d
@trxcllnt
add gtest to raft-exports, remove dead code
713a872
@trxcllnt
update CMake faiss variable name
ceb4d8b
@trxcllnt
make -v set cmake --log-level=VERBOSE
1d3ffab
@trxcllnt
update cuco hash to the commit that uses rapids-cmake v21.12
b48e393
@trxcllnt
Merge branch 'branch-21.12' of github.com:rapidsai/raft into fix/buil…
dc076ae 
…d-shared-faiss
@trxcllnt
Merge branch 'branch-21.12' of github.com:rapidsai/raft into fix/buil…
e824384 
…d-shared-faiss
@trxcllnt
Merge branch 'branch-21.12' of github.com:rapidsai/raft into fix/buil…
078e33c 
…d-shared-faiss
@trxcllnt
Merge branch 'branch-22.02' of github.com:rapidsai/raft into fix/buil…
30dafb6 
…d-shared-faiss
@trxcllnt
update cuco version
aedc6d7
@trxcllnt
Merge branch 'branch-22.02' of github.com:rapidsai/raft into fix/buil…
245ea3d 
…d-shared-faiss
dantegd
dantegd requested changes Jan 25, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to see the progress towards the multiple conda packaging!

build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Show resolved Hide resolved
conda/recipes/libraft_distance/build.sh Outdated Show resolved Hide resolved
conda/recipes/libraft_distance/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libraft_nn/meta.yaml Show resolved Hide resolved
conda/recipes/pyraft/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/pyraft/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/pyraft/meta.yaml Show resolved Hide resolved
conda/recipes/pyraft/meta.yaml Outdated Show resolved Hide resolved
@cjnolet cjnolet changed the base branch from branch-22.02 to branch-22.04 January 25, 2022 23:27
jjacobelli
jjacobelli reviewed Jan 26, 2022
View reviewed changes
conda/recipes/libraft_distance/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libraft_headers/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libraft_nn/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/pyraft/meta.yaml Outdated Show resolved Hide resolved
ajschmidt8
ajschmidt8 reviewed Jan 26, 2022
View reviewed changes
ci/checks/changelog.sh Outdated Show resolved Hide resolved
dantegd
dantegd requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, just had 2 super minor remaining questions

conda/recipes/libraft_nn/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/libraft_nn/meta.yaml Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Jan 26, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4a13ea7 into rapidsai:branch-22.04 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 left review comments

@dantegd dantegd dantegd approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjnolet @ajschmidt8 @dantegd @jakirkham @jjacobelli @BradReesWork @trxcllnt @robertmaynard @shwina