Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 support #2417

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

Notes for Reviewers

How I tested this

Checked that there were no remaining uses like this:

git grep -E '3\.9'
git grep '39'
git grep 'py39'

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 22, 2024
@jameslamb jameslamb marked this pull request as ready for review August 22, 2024 14:33
@jameslamb jameslamb requested a review from a team as a code owner August 22, 2024 14:33
@jakirkham
Copy link
Member

jakirkham commented Aug 23, 2024

One of the C++ tests failed in this CI job

That said, this is simply cleaning up Python bits (not touching C++). So it doesn't seem caused by these changes (nor related)

Filing issue ( #2418 ) to track. Will also mention this offline

Since it only happens in that one job, it looks flaky. Will trying restarting to see if it goes away

Edit: Looks like it cleared up

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 73dc36c into rapidsai:branch-24.10 Aug 23, 2024
57 of 58 checks passed
@jakirkham
Copy link
Member

Thanks James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants