Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve update-version.sh #2408

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Improve update-version.sh #2408

merged 2 commits into from
Aug 8, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 7, 2024

This PR improves update-version.sh by clarifying suffix handling and ucxx/ucx-py version handling.

@bdice bdice requested a review from a team as a code owner August 7, 2024 14:49
@bdice bdice requested a review from AyodeAwe August 7, 2024 14:49
@github-actions github-actions bot added the ci label Aug 7, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 7, 2024
jameslamb
jameslamb approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm especially happy to see literal -cu11 and -cu12 replaces with regexes that won't have to be updated for future CUDA versions.

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit dbdde82 into rapidsai:branch-24.10 Aug 8, 2024
69 checks passed
@bdice
Copy link
Contributor Author

bdice commented Aug 8, 2024

Nice! I'm especially happy to see literal -cu11 and -cu12 replaces with regexes that won't have to be updated for future CUDA versions.

This was why I began this round of updates across RAPIDS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @jameslamb