Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binarize Dice Distance for Dense Inputs #2370

Merged
merged 16 commits into from
Jul 10, 2024

Conversation

aamijar
Copy link
Contributor

@aamijar aamijar commented Jun 28, 2024

Instead of binarizing in pairwise_distances() in cuml, do it in the distance function in raft.

@aamijar aamijar requested a review from a team as a code owner June 28, 2024 05:19
Copy link

copy-pr-bot bot commented Jun 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the cpp label Jun 28, 2024
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 28, 2024
@cjnolet
Copy link
Member

cjnolet commented Jun 28, 2024

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jul 2, 2024

/ok to test

@lowener
Copy link
Contributor

lowener commented Jul 9, 2024

/ok to test

@lowener
Copy link
Contributor

lowener commented Jul 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit 5bf6642 into rapidsai:branch-24.08 Jul 10, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants