resolve dependency-file-generator warning, other rapids-build-backend followup #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
added
3 - Ready for Review
and removed
2 - In Progress
jameslamb
changed the title
KyleFromNVIDIA
approved these changes
Jun 12, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89
Since #2331 was merged, we've made some small adjustments to the approach for
rapids-build-backend. This catchesraftup with those changes:ci/scripts--file-keyinstead of--file_keyinrapids-dependency-file-generatorcallsrapids-build-backendversion constraint independencies.yaml, and renames some lists there to match the patterns used in other projects (e.g.rapids_build_skbuildinstead ofbuild)