Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Dice Distance for Dense Inputs #2359

Merged
merged 12 commits into from
Jun 24, 2024
Merged

[FEA] Dice Distance for Dense Inputs #2359

merged 12 commits into from
Jun 24, 2024

Conversation

aamijar
Copy link
Contributor

@aamijar aamijar commented Jun 12, 2024 •
edited
Loading

Adds support for the DistanceType::DiceExpanded for dense inputs.

  1. Naive Kernel Implementation (unexpanded form)
  2. Expanded form for dice distance that follows ground truth from scipy.spatial.distance.dice
  3. Gtests in cpp/test/distance/dist-dice.cu

Related to rapidsai/cuml#5129

@aamijar aamijar requested review from a team as code owners June 12, 2024 17:34
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@divyegala divyegala added feature request New feature or request non-breaking Non-breaking change labels Jun 13, 2024
@divyegala
Copy link
Member

/ok to test

@divyegala
Copy link
Member

/ok to test

@aamijar aamijar mentioned this pull request Jun 18, 2024
Open
@divyegala
Copy link
Member

/ok to test

@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b863f18 into rapidsai:branch-24.08 Jun 24, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
CMake cpp feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aamijar @divyegala