Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build C++ wheel (#2264)" #2305

Merged
merged 1 commit into from
May 10, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 9, 2024

This reverts commit b760453.

The various issues around symbol visibility caused by raft currently supporting a mix of compiled library and header-only usage make this wheel unsafe to use in various environments at the moment. We will revisit this work once all of the compiled components of raft are fully split out into cuvs.

@vyasr vyasr self-assigned this May 9, 2024
@vyasr vyasr requested review from a team as code owners May 9, 2024 22:52
@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels May 9, 2024
@cjnolet
Copy link
Member

cjnolet commented May 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit ea54c79 into rapidsai:branch-24.06 May 10, 2024
70 checks passed
@vyasr vyasr deleted the chore/revert_cpp_wheel branch May 10, 2024 17:22
vyasr added a commit that referenced this pull request May 10, 2024
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
This reverts commit b760453.


The various issues around symbol visibility caused by raft currently supporting a mix of compiled library and header-only usage make this wheel unsafe to use in various environments at the moment. We will revisit this work once all of the compiled components of raft are fully split out into cuvs.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#2305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci CMake cpp non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

3 participants