[REVIEW] Adjust UCX dependencies #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
May 9, 2024
vyasr
added
improvement
pentschev
force-pushed
the
ucxx-dependencies
branch
from
28631a1
to
2c14e6e
Compare
Add `distributed-ucxx` as a required dependency to `raft-dask` and remove direct dependencies to `ucx`/`ucx-proc` in favor of transitive installation from `ucx-py`/distributed-ucxx`.
pentschev
force-pushed
the
ucxx-dependencies
branch
from
2c14e6e
to
6baaeba
Compare
raydouglass
reviewed
May 10, 2024
There was a problem hiding this comment.
Looks like the conda recipe might need to be updated as well?
https://github.com/rapidsai/raft/blob/branch-24.06/conda/recipes/raft-dask/meta.yaml#L76-L77
raydouglass
approved these changes
May 10, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
distributed-ucxxas a required dependency toraft-daskand remove direct dependencies toucx/ucx-procin favor of transitive installation fromucx-py/distributed-ucxx.