Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to raft-ann-bench docs #1905

Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Oct 16, 2023

Refactoring the docs a bit more to make them easier to follow

@cjnolet cjnolet added doc Documentation non-breaking Non-breaking change labels Oct 16, 2023
@cjnolet cjnolet self-assigned this Oct 16, 2023
@cjnolet cjnolet requested a review from a team as a code owner October 16, 2023 22:24
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-org looks much better, just have a few small suggestions

docs/source/raft_ann_benchmarks.md Outdated Show resolved Hide resolved
docs/source/raft_ann_benchmarks.md Outdated Show resolved Hide resolved
docs/source/raft_ann_benchmarks.md Outdated Show resolved Hide resolved
docs/source/raft_ann_benchmarks.md Outdated Show resolved Hide resolved
docs/source/raft_ann_benchmarks.md Outdated Show resolved Hide resolved
Comment on lines +419 to +420


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straggling blank lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this when I was moving things around because I kept losing my place. I don't think it's hurting anything visually but we can remove it in a follow-on. It's getting late and I want to make sure these changes are ready and deployed for tomorrow.

docs/source/raft_ann_benchmarks.md Outdated Show resolved Hide resolved
Co-authored-by: Dante Gama Dessavre <dante.gamadessavre@gmail.com>
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cjnolet
Copy link
Member Author

cjnolet commented Oct 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit f7835fa into rapidsai:branch-23.12 Oct 17, 2023
62 checks passed
divyegala pushed a commit to divyegala/raft that referenced this pull request Oct 17, 2023
Refactoring the docs a bit more to make them easier to follow

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#1905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

3 participants