Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cagra multi CTA bug #1628

Merged
merged 8 commits into from
Jul 4, 2023
Merged

Fix cagra multi CTA bug #1628

merged 8 commits into from
Jul 4, 2023

Conversation

enp1s0
Copy link
Member

@enp1s0 enp1s0 commented Jun 30, 2023 •
edited
Loading

rel: #1575

The main causes of the bug are the wrong memory allocation size and the wrong number of threads to be launched.

@enp1s0 enp1s0 requested a review from a team as a code owner June 30, 2023 07:54
@github-actions github-actions bot added the cpp label Jun 30, 2023
@enp1s0 enp1s0 added bug Something isn't working non-breaking Non-breaking change and removed cpp labels Jun 30, 2023
@github-actions github-actions bot added the cpp label Jun 30, 2023
@enp1s0
Copy link
Member Author

enp1s0 commented Jun 30, 2023

@tfeher Can you review the code?

@enp1s0 enp1s0 requested a review from tfeher June 30, 2023 11:09
@enp1s0 enp1s0 self-assigned this Jun 30, 2023
cjnolet
cjnolet approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @enp1s0! Once conflicts are resolved, I can merge this.

@cjnolet
Copy link
Member

cjnolet commented Jul 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit cc1d1ed into rapidsai:branch-23.08 Jul 4, 2023
51 checks passed
@tfeher tfeher mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@tfeher tfeher Awaiting requested review from tfeher

Assignees

@enp1s0 enp1s0

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enp1s0 @cjnolet