Re-use memory pool between benchmark runs #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't recreate a new memory pool for each benchmark, and instead re-use the pool. This significantly speeds up running the benchmarks that use the cuda memory pool. As an example running `time ./cpp/build/MATRIX_BENCH --benchmark_filter=SelectK/float/uint32_t.*/0/` which runs benchmarks for 9 different selection algorithms - the times are reduced from `0m36.317s` on branch-23.06 to `0m10.038s` with this change.
benfred
added
improvement
divyegala
reviewed
May 8, 2023
| if (use_pool_memory_resource) { | ||
| if (!memory_pool) { memory_pool.reset(new using_pool_memory_res()); } | ||
| } else if (memory_pool) { | ||
| memory_pool.reset(); |
There was a problem hiding this comment.
I'm not following what an empty reset() is doing here. I'm reading this line as "a new memory pool is created", but your analysis shows that's not the case. Could you please explain?
There was a problem hiding this comment.
This frees the memory being allocated by the memory pool - like in this case use_pool_memory_resource is false, and the empty reset will free up any previously allocated memory pool.
divyegala
approved these changes
May 9, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't recreate a new memory pool for each benchmark, and instead re-use the pool.
This significantly speeds up running the benchmarks that use a cuda memory pool. As an example running
time ./cpp/build/MATRIX_BENCH --benchmark_filter=SelectK/float/uint32_t.*/0/which runs benchmarks for 9 different selection algorithms - the time to run the benchmarks is reduced from36.317son branch-23.06 to10.038swith this change.