[ENH] Enable building with clang (limit strict error checking to GCC) #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only do strict error checking when the host compiler is GCC.
ahendriksen
changed the title
ahendriksen
added
3 - Ready for Review
improvement
|
To be clear, the goal here is just to use clang as the compiler for host code, not device code, right? The latter requires a great deal more work AFAIR (much of it also upstream). |
|
Yes indeed. The goal is to compile with Clang as host compiler. |
cjnolet
approved these changes
Apr 25, 2023
|
/merge |
ahendriksen
added a commit
to ahendriksen/raft
that referenced
this pull request
Apr 27, 2023
…dsai#1452) Compiling RAFT with a non-GCC compiler can be tricky as there is very strict error checking (`-Werror=all-warnings` for instance) and therefore, the build is almost guaranteed to fail due to warnings elevated to errors. I am sometimes building RAFT with clang because of its `-ftime-trace` feature, which helps find code that increases compile times. This PR contains the changes I typically make to the CMakeLists.txt to enable clang compilation. With this change, strict error checking is only performed when the host compiler is GCC. Tested with clang version 11.1. Authors: - Allard Hendriksen (https://github.com/ahendriksen) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling RAFT with a non-GCC compiler can be tricky as there is very strict error checking (
-Werror=all-warningsfor instance) and therefore, the build is almost guaranteed to fail due to warnings elevated to errors.I am sometimes building RAFT with clang because of its
-ftime-tracefeature, which helps find code that increases compile times.This PR contains the changes I typically make to the CMakeLists.txt to enable clang compilation. With this change, strict error checking is only performed when the host compiler is GCC.
Tested with clang version 11.1.