Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for function exposing KNN merge #1418

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Fix for function exposing KNN merge #1418

merged 6 commits into from
Jun 26, 2023

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner April 14, 2023 16:55
@github-actions github-actions bot added the cpp label Apr 14, 2023
@cjnolet cjnolet added bug Something isn't working improvement Improvement / enhancement to an existing function labels Apr 14, 2023
cjnolet
cjnolet approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this just popping up because Legate is enforcing const inputs or is this exposing a lack of testing on the RAFT side? I notice CI is tripping on this change but is this being tested?

@viclafargue
Copy link
Contributor Author

Yes, there were multiple issues during compilation. It doesn't appear to be tested anywhere. Do you want me to add some tests?

@cjnolet cjnolet added non-breaking Non-breaking change and removed improvement Improvement / enhancement to an existing function labels Apr 25, 2023
@viclafargue viclafargue changed the base branch from branch-23.06 to branch-23.08 June 23, 2023 10:31
@cjnolet
Copy link
Member

cjnolet commented Jun 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit 1034a41 into rapidsai:branch-23.08 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@viclafargue viclafargue

Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viclafargue @cjnolet