Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch signal handler change error #1147

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Catch signal handler change error #1147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0751657
Ignore error during signal handler change
tfeher Jan 17, 2023
7e74772
Merge branch 'branch-23.02' into bug-interruptible-dask
tfeher Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions python/pylibraft/pylibraft/common/interruptible.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,17 @@ def cuda_interruptible():
with nogil:
dereference(token).cancel()

oldhr = signal.signal(signal.SIGINT, newhr)
try:
oldhr = signal.signal(signal.SIGINT, newhr)
except ValueError:
# the signal creation would fail if this is not the main thread
# That's fine! The feature is disabled.
oldhr = None
try:
yield
finally:
signal.signal(signal.SIGINT, oldhr)
if oldhr is not None:
signal.signal(signal.SIGINT, oldhr)


def synchronize(stream: Stream):
Expand Down