Skip to content

Commit

Permalink
Adjusting end-to-end start time so it doesn't include stream creation…
Browse files Browse the repository at this point in the history
… time (#1989)

We can safely assume all cuda streams have been created before we run benchmark experiments. With the sensitivity to latencies for smaller batch sizes, this has an impact on overall throughput.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Ben Frederickson (https://github.com/benfred)

URL: #1989
  • Loading branch information
cjnolet authored Nov 14, 2023
1 parent 9110531 commit 9f84648
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cpp/bench/ann/src/common/benchmark.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,8 @@ void bench_search(::benchmark::State& state,
std::shared_ptr<buf<std::size_t>> neighbors =
std::make_shared<buf<std::size_t>>(algo_property.query_memory_type, k * query_set_size);

auto start = std::chrono::high_resolution_clock::now();
cuda_timer gpu_timer;
auto start = std::chrono::high_resolution_clock::now();
{
nvtx_case nvtx{state.name()};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def convert_json_to_csv_search(dataset, dataset_path):
write["build cpu_time"] = None
write["build GPU"] = None

for col_idx in range(5, len(build_df.columns)):
for col_idx in range(6, len(build_df.columns)):
col_name = build_df.columns[col_idx]
write[col_name] = None

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@

- name: wiki_all_1M
dims: 768
base_file: wiki_all_1M/base.1MM.fbin
base_file: wiki_all_1M/base.1M.fbin
query_file: wiki_all_1M/queries.fbin
groundtruth_neighbors_file: wiki_all_1M/groundtruth.1M.neighbors.ibin
distance: euclidean
Expand Down

0 comments on commit 9f84648

Please sign in to comment.