Skip to content

Commit

Permalink
Use the new RAPIDS.cmake to fetch rapids-cmake (#298)
Browse files Browse the repository at this point in the history
The original approach of using FetchContent naively has a subtle
bug when multiple projects that use rapids-cmake are combined together inside as sibling projects. This bug causes any
`include(rapids-*)` commands to fail, causing CMake errors.

Bug using `RAPIDS.cmake` we can resolve this issue and remove
the new complex logic from each consumer.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #298
  • Loading branch information
robertmaynard authored Jul 26, 2021
1 parent 0e7642a commit 300fcd7
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,9 @@
#=============================================================================

cmake_minimum_required(VERSION 3.20.1 FATAL_ERROR)
include(FetchContent)
FetchContent_Declare(
rapids-cmake
GIT_REPOSITORY https://github.com/rapidsai/rapids-cmake.git
GIT_TAG origin/branch-21.08
)
FetchContent_MakeAvailable(rapids-cmake)
file(DOWNLOAD https://github.com/raw/rapidsai/rapids-cmake/branch-21.10/RAPIDS.cmake
${CMAKE_BINARY_DIR}/RAPIDS.cmake)
include(${CMAKE_BINARY_DIR}/RAPIDS.cmake)
include(rapids-cmake)
include(rapids-cpm)
include(rapids-cuda)
Expand Down

0 comments on commit 300fcd7

Please sign in to comment.