Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Open gcc pinning to allow for new conda-forge gcc 9.3 pkgs #199

Merged
merged 1 commit into from
Dec 15, 2020
Merged

ENH Open gcc pinning to allow for new conda-forge gcc 9.3 pkgs #199

merged 1 commit into from
Dec 15, 2020

Conversation

mike-wendt
Copy link
Contributor

@mike-wendt mike-wendt commented Dec 14, 2020 •
edited
Loading

Blocks #198

Update our pinning for libgcc-ng, libgfortran-ng, & libstdcxx-ng from =7.5.0 to >=7.5.0 to allow for pulling gcc 9.3 packages that are being built on conda-forge

  • Run tests to check stability of build stack with allowing gcc 9.3 built packages from conda-forge

@mike-wendt
TST Unpin build_stack
423f523 
Run tests to check stability of build stack with allowing gcc 9.3 built packages from conda-forge
@mike-wendt mike-wendt added 3 - Ready for Review Ready for review by team conda 4 - Needs Tests Waiting for test results to make a decision labels Dec 14, 2020
@mike-wendt mike-wendt self-assigned this Dec 14, 2020
@mike-wendt mike-wendt requested a review from a team as a code owner December 14, 2020 23:09
@mike-wendt mike-wendt added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Dec 14, 2020
@mike-wendt
Copy link
Contributor Author

Wait for test result review to determine if this should be merged

ajschmidt8
ajschmidt8 requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rejecting these changes to remove this PR from our daily reminders.

@mike-wendt mike-wendt changed the title TST Unpin build_stack ENH Open gcc pinning to allow for new conda-forge gcc 9.3 pkgs Dec 15, 2020
@mike-wendt
Copy link
Contributor Author

mike-wendt commented Dec 15, 2020 •
edited
Loading

@jakirkham @kkraus14 any objections or concerns? I don't think we'll face the same issues we had with 7.3 -> 7.5 so this should be good to go and the builds for both env/meta-pkgs build without solver issues

@mike-wendt mike-wendt added 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 3 - Ready for Review Ready for review by team 4 - Needs Tests Waiting for test results to make a decision 5 - DO NOT MERGE Hold off on merging; see PR for details labels Dec 15, 2020
@mike-wendt mike-wendt requested a review from a team December 15, 2020 21:08
@mike-wendt mike-wendt merged commit f3d4b40 into branch-0.18 Dec 15, 2020
@mike-wendt mike-wendt deleted the tst-unpinned-build-stack branch December 15, 2020 22:36
This was referenced Dec 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@kkraus14 kkraus14 Awaiting requested review from kkraus14

Assignees

@mike-wendt mike-wendt

Labels
4 - Needs Reviewer Waiting for reviewer to review or respond conda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-wendt @jakirkham @ajschmidt8