Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTD configuration and references to RTD page #1211

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

charlesbluca
Copy link
Member

It's been some time since we started having the RTD page redirect to the RAPIDS docs, we should be good to remove the configuration files controlling this along with some outdated references to the old page.

Note that this won't actually unpublish the RTD redirect page, to do that we would need to delete the dask-cuda project from readthedocs.org - not opposed to doing this but figured it would make more sense to make less impactful changes first.

cc @bdice @pentschev

@charlesbluca charlesbluca requested a review from a team as a code owner July 18, 2023 19:56
@github-actions github-actions bot added the python python code needed label Jul 18, 2023
Comment on lines +147 to +148
"https://docs.rapids.ai/api/dask-cuda/nightly/ucx/ "
"for more details"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed like the section the original link was pointing to doesn't exist anymore, is there any specific place on the UCX integration docs we'd like to point this to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This links looks like the correct one to me.

@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Jul 18, 2023
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team doc Documentation and removed 3 - Ready for Review Ready for review by team doc Documentation labels Jul 18, 2023
@jakirkham
Copy link
Member

Sorry think we updated the labels at the same time (was trying to fix the label checker). Please check and make sure we have all the labels we want to include

@jakirkham
Copy link
Member

Should we also disable RTD builds of this repo?

@charlesbluca
Copy link
Member Author

Should we also disable RTD builds of this repo?

It looks like the project has been pointed at branch-21.06 for some time now, so builds effectively haven’t been running for 2 years or so; don't see a setting to explicitly disable builds but suppose we could remove the GitHub webhook integrations which should further disable things?

At that point I would lean towards deleting the project (unless we anticipate moving back to RTD some time in the future?) so that the redirect link and other associated RTD maintainer pings for the project stop.

@pentschev
Copy link
Member

At that point I would lean towards deleting the project (unless we anticipate moving back to RTD some time in the future?) so that the redirect link and other associated RTD maintainer pings for the project stop.

If we delete the project, do we run into risks of having someone else taking ownership, similar to what could happen with names in PyPI? If so, I would be strongly against that, we should retain ownership.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @charlesbluca !

@jakirkham
Copy link
Member

jakirkham commented Jul 18, 2023

Agree with Peter. Let's keep the project. It will also keep the redirect going to RAPIDS (if there are old links to RTD still out there)

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakirkham jakirkham removed the improvement Improvement / enhancement to an existing function label Jul 18, 2023
@jakirkham
Copy link
Member

Dropped one label to fix the label checker

@jakirkham
Copy link
Member

jakirkham commented Jul 18, 2023

CI failures are the same observed in this comment ( #1210 (comment) )

As Peter noted offline, this appears to be related to upstream Distributed changes

@wence-
Copy link
Contributor

wence- commented Jul 19, 2023

CI failures are the same observed in this comment ( #1210 (comment) )

As Peter noted offline, this appears to be related to upstream Distributed changes

Fixed by #1212

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 8ff7af9 into rapidsai:branch-23.08 Jul 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants