-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RTD configuration and references to RTD page #1211
Conversation
"https://docs.rapids.ai/api/dask-cuda/nightly/ucx/ " | ||
"for more details" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed like the section the original link was pointing to doesn't exist anymore, is there any specific place on the UCX integration docs we'd like to point this to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This links looks like the correct one to me.
Sorry think we updated the labels at the same time (was trying to fix the label checker). Please check and make sure we have all the labels we want to include |
Should we also disable RTD builds of this repo? |
It looks like the project has been pointed at At that point I would lean towards deleting the project (unless we anticipate moving back to RTD some time in the future?) so that the redirect link and other associated RTD maintainer pings for the project stop. |
If we delete the project, do we run into risks of having someone else taking ownership, similar to what could happen with names in PyPI? If so, I would be strongly against that, we should retain ownership. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @charlesbluca !
Agree with Peter. Let's keep the project. It will also keep the redirect going to RAPIDS (if there are old links to RTD still out there) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Dropped one label to fix the label checker |
CI failures are the same observed in this comment ( #1210 (comment) ) As Peter noted offline, this appears to be related to upstream Distributed changes |
Fixed by #1212 |
/merge |
It's been some time since we started having the RTD page redirect to the RAPIDS docs, we should be good to remove the configuration files controlling this along with some outdated references to the old page.
Note that this won't actually unpublish the RTD redirect page, to do that we would need to delete the dask-cuda project from readthedocs.org - not opposed to doing this but figured it would make more sense to make less impactful changes first.
cc @bdice @pentschev