Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement has_edge() & compute_multiplicity() #4096

Merged
merged 21 commits into from
Jan 25, 2024

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Jan 17, 2024

graph_view.has_edge() query whether the graph has given (src, dst) pairs as edges.

graph_view.compute_multiplicity() query the edge multiplicity of given (src, dst) pairs (assumes that multiplicity is 0 if there is no edge between a given pair). This function throws an exception if graph_view.is_multigraph() is false (better use has_edge() for non-multigraph).

In addition to adding the above two functions, this PR includes few code cleanups.

  • major_idx_from_major_nocheck() to edge_partition_device_view_t
  • Move count_invalid_vertex_pais from nbr_intersection.cuh to error_check_utils.cuh
  • Update cugraph::test::to_host, to_device, device_gatherv, and device_allgatherv to support bool type (and to handle std::vector<bool> which stores bool values in a packed format)

@seunghwak seunghwak added feature request New feature or request DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Jan 17, 2024
@seunghwak seunghwak added this to the 24.02 milestone Jan 17, 2024
@seunghwak seunghwak self-assigned this Jan 17, 2024
@seunghwak
Copy link
Contributor Author

@jnke2016 I need to write tests to merge this PR but you can use this PR to continue K-truss implementation.

@github-actions github-actions bot added the CMake label Jan 17, 2024
@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 18, 2024
@seunghwak seunghwak marked this pull request as ready for review January 18, 2024 01:10
@seunghwak seunghwak requested a review from a team as a code owner January 18, 2024 01:10
@seunghwak seunghwak requested a review from a team as a code owner January 18, 2024 01:10
@seunghwak
Copy link
Contributor Author

@jnke2016 Now this PR is ready for your testing in K-truss.

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 3526af4 into rapidsai:branch-24.02 Jan 25, 2024
97 checks passed
@seunghwak seunghwak deleted the fea_has_edges branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cuGraph feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants