Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE - only for CI/artifacts] cudf-polars testing #16492

Closed
wants to merge 21 commits into from

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Aug 5, 2024

Description

DO NOT MERGE, just to produce CI artifacts.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lithomas1 lithomas1 added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Aug 5, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (445a75f) to head (7cf3289).
Report is 2 commits behind head on branch-24.08.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-24.08   #16492      +/-   ##
================================================
- Coverage         83.28%   83.28%   -0.01%     
================================================
  Files               184      184              
  Lines             28318    28318              
================================================
- Hits              23586    23585       -1     
- Misses             4732     4733       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lithomas1 and others added 2 commits August 5, 2024 15:17
## Description
<!-- Provide a standalone description of changes in this PR. -->
<!-- Reference any issues closed by this PR with "closes #1234". -->
<!-- Note: The pull request title will be included in the CHANGELOG. -->

Adapts to IR changes in polars 1.4 and handles nrows/skiprows a little
more correctly.

## Checklist
- [ ] I am familiar with the [Contributing
Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md).
- [ ] New or existing tests cover these changes.
- [ ] The documentation is up to date with these changes.

---------

Co-authored-by: Lawrence Mitchell <lmitchell@nvidia.com>
Add support for ``pl.col.str.replace`` and ``pl.col.str.replace_many``

Authors:
  - Thomas Li (https://github.com/lithomas1)

Approvers: None

URL: #16039
@vyasr
Copy link
Contributor

vyasr commented Aug 16, 2024

This PR exists solely to produce builds of the latest version of cudf-polars until the release because we do not have branch builds set up on the cudf-polars feature branch. This PR can be closed after the release and should never be merged.

@lithomas1 lithomas1 changed the title cudf-polars testing [DO NOT MERGE - only for CI/artifacts] cudf-polars testing Aug 16, 2024
@github-actions github-actions bot added the pylibcudf Issues specific to the pylibcudf package label Aug 20, 2024
lithomas1 and others added 5 commits August 20, 2024 15:16
contributes to #16478

This implements "cum_min", "cum_max", "cum_prod", "cum_sum"

"cum_count" is not implemented for now, since there's no exact libcudf match (I imagine the non-grouped case is also not used that much but haven't checked).
I suppose we could implement it by creating a column of 1s and copying the null mask over, and doing a cum_sum on that.
Let me know if you want to try that.

Authors:
  - Thomas Li (https://github.com/lithomas1)

Approvers:
  - https://github.com/brandon-b-miller

URL: #16509
Use a key column rather than a placeholder for count agg
Copy link

copy-pr-bot bot commented Aug 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 26, 2024
@lithomas1
Copy link
Contributor Author

Closing since the CI auto-trigger doesn't work for me anymore :(.

Someone else should do a new pull request.

cc @vyasr

@vyasr
Copy link
Contributor

vyasr commented Aug 28, 2024

Thanks for the ping! The new PR is #16680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - DO NOT MERGE Hold off on merging; see PR for details cudf.polars Issues specific to cudf.polars libcudf Affects libcudf (C++/CUDA) code. pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants