Fix build failures with GCC 13 #16488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
bug
PointKernel
commented
Aug 2, 2024
Comment on lines
-40
to
-52
| class cuco_allocator | ||
| : public rmm::mr::stream_allocator_adaptor<rmm::mr::polymorphic_allocator<char>> { | ||
| /// Default stream-ordered allocator type | ||
| using default_allocator = rmm::mr::polymorphic_allocator<char>; | ||
| /// The base allocator adaptor type | ||
| using base_type = rmm::mr::stream_allocator_adaptor<default_allocator>; | ||
|
|
||
| public: | ||
| /** | ||
| * @brief Constructs the allocator adaptor with the given `stream` | ||
| */ | ||
| cuco_allocator(rmm::cuda_stream_view stream) : base_type{default_allocator{}, stream} {} | ||
| }; |
There was a problem hiding this comment.
The existing cuco_allocator convenience wrapper cannot pass a build time check with GCC 13 where it requires rmm::mr::stream_allocator_adaptor<rmm::mr::polymorphic_allocator<char>> and cuco_allocator to be the same type.
davidwendt
approved these changes
Aug 2, 2024
PointKernel
changed the title
harrism
approved these changes
Aug 5, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #16395
This PR resolves two types of compilation errors, allowing for successful builds with GCC 13:
cuco_allocatorstrong type with an alias to fix a new build time check with GCC 13std::movewhen returning a temporaryChecklist