Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop duplicates C++ example #16462

Conversation

srinivasyadav18
Copy link
Contributor

Description

This PR adds drop duplicates C++ example using distinct API with four different keep options.
The example source file uses a csv file containing bank transactions of customers on a single day, for building and processing the table using distinct algorithm.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Aug 1, 2024
@srinivasyadav18 srinivasyadav18 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Aug 1, 2024
@GregoryKimball
Copy link
Contributor

Thank you @srinivasyadav18 this looks like a perfect start!

  • Would you please add the filename as a CLI parameter that defaults to this transactions.csv file?
  • Would you please use the simple timer from the other examples and add console prints for the wall time of distinct calls?
  • Question: should we convert this to JSON so that we can benchmark nested types?

@GregoryKimball
Copy link
Contributor

We are closing this in favor of presenting performance data from stream compaction nvbenchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants