Disallow cudf.Series to accept column in favor of ._from_column
#16454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
galipremsagar
approved these changes
Aug 7, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Aug 9, 2024
closes #6017 With rapidsai/cudf#16454, `cudf.Series` no longer accepts cudf `ColumnBase` objects. The usage of this pattern in cuml was mostly not needed as there existed public APIs to avoid this behavior Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Bradley Dice (https://github.com/bdice) - Dante Gama Dessavre (https://github.com/dantegd) URL: #6019
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Aug 9, 2024
…#1434) closes #1433 Mirroring the upstream cudf changes in rapidsai/cudf#16454, `cudf.Series` disallows accepting a `ColumnBase` in favor of the `cudf.Series._from_column` constructor. This PR does the same for `GeoSeries` as well as addresses the breakages due to the upstream cudf change. Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) URL: #1434
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
Similar to #16454, this PR disallows the public `cudf.Index` accepting a private `ColumnBase` object in favor of `_from_column` (which was added in the linked PR) Authors: - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #16549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cudf.Seriesis a public constructor that happens to accept a privateColumnBaseobject. Many ops return Columns and is natural to want to reconstruct aSeries.This PR adds a
SingleColumnFrame._from_columnclassmethod for instances where we need to wrap a new column in anIndexorSeries. This constructor also passes some unneeded validation inColumnAccessorandSeriesChecklist