Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove squeeze argument from groupby #16312

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mroeschke
Copy link
Contributor

Description

In pandas, this argument was deprecated in pandas 1.x and removed in pandas 2.x. xref pandas-dev/pandas#33218

Looks like in cudf this argument was never implemented, so to align with pandas, I think it should be OK to just remove this argument

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 18, 2024
@mroeschke mroeschke requested a review from a team as a code owner July 18, 2024 22:05
@vyasr
Copy link
Contributor

vyasr commented Jul 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3df4ac2 into rapidsai:branch-24.08 Jul 19, 2024
79 checks passed
@mroeschke mroeschke deleted the rm/gb/squeeze branch July 19, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants