Support pd.read_pickle and pd.to_pickle in cudf.pandas
#16105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
Matt711
commented
Jun 26, 2024
| @@ -937,8 +938,13 @@ def _fast_slow_function_call( | |||
| domain="cudf_pandas", | |||
| ): | |||
| slow_args, slow_kwargs = _slow_arg(args), _slow_arg(kwargs) | |||
| with disable_module_accelerator(): | |||
| result = func(*slow_args, **slow_kwargs) | |||
| if args[0].__name__ == "read_pickle": | |||
There was a problem hiding this comment.
result = func(*slow_args, **slow_kwargs) led to infinite recursion so I had to get the argument needed for read_pickle. Is there a better way to do this?
There was a problem hiding this comment.
Curious what is the part leading to recursion?
If the goal is to always just call pandas' read_pickle/to_pickle, it may make sense to manually define these method wrapper in python/cudf/cudf/pandas/_wrappers/pandas.py.
Matt711
changed the title
pd.read_pickle in cudf.pandaspd.read_pickle and pd.to_pickle in cudf.pandas
Matt711
force-pushed
the
feature/support-pandas-pickling
branch
from
b604a54
to
a6375a0
Compare
…support-pandas-pickling
vyasr
approved these changes
Jun 27, 2024
wence-
reviewed
Jul 4, 2024
wence-
requested changes
Jul 4, 2024
…support-pandas-pickling
…support-pandas-pickling
wence-
reviewed
Jul 8, 2024
mroeschke
approved these changes
Jul 9, 2024
wence-
approved these changes
Jul 9, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #15459
Checklist