Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo bug in gather implementation #16000

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix typo bug in gather implementation #16000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/cudf_polars/cudf_polars/dsl/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ def do_evaluate(
obj = plc.replace.replace_nulls(
indices.obj,
plc.interop.from_arrow(
pa.scalar(n, type=plc.interop.to_arrow(indices.obj.data_type()))
pa.scalar(n, type=plc.interop.to_arrow(indices.obj.type()))
),
)
else:
Expand Down
31 changes: 31 additions & 0 deletions python/cudf_polars/tests/expressions/test_gather.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@
# SPDX-License-Identifier: Apache-2.0
from __future__ import annotations

import pytest

import polars as pl

from cudf_polars import execute_with_cudf
from cudf_polars.testing.asserts import assert_gpu_result_equal


Expand All @@ -17,3 +20,31 @@ def test_gather():

query = ldf.select(pl.col("a").gather(pl.col("b")))
assert_gpu_result_equal(query)


def test_gather_with_nulls():
ldf = pl.LazyFrame(
{
"a": [1, 2, 3, 4, 5, 6, 7],
"b": [0, None, 1, None, 6, 1, 0],
}
)

query = ldf.select(pl.col("a").gather(pl.col("b")))

assert_gpu_result_equal(query)


@pytest.mark.parametrize("negative", [False, True])
def test_gather_out_of_bounds(negative):
ldf = pl.LazyFrame(
{
"a": [1, 2, 3, 4, 5, 6, 7],
"b": [0, -10 if negative else 10, 1, 2, 6, 1, 0],
}
)

query = ldf.select(pl.col("a").gather(pl.col("b")))

with pytest.raises(pl.exceptions.ComputeError):
query.collect(post_opt_callback=execute_with_cudf)
Loading