Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo bug in gather implementation #16000

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 12, 2024

Description

Pylibcudf calls the datatype accessor type(). Add tests to cover this case, and raising on out of bounds accesses.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Pylibcudf calls the datatype accessor type(). Add tests to cover this
case, and raising on out of bounds accesses.
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@wence- wence- requested a review from a team as a code owner June 12, 2024 15:23
@wence- wence- requested review from bdice and lithomas1 June 12, 2024 15:23
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Jun 12, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on PR 16000!

@wence-
Copy link
Contributor Author

wence- commented Jun 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 97518ac into rapidsai:branch-24.08 Jun 12, 2024
79 checks passed
@wence- wence- deleted the wence/fea/gather-coverage branch June 12, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants