-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc Column cleanups #15682
Misc Column cleanups #15682
Conversation
@@ -820,7 +818,7 @@ def take( | |||
|
|||
# TODO: For performance, the check and conversion of gather map should | |||
# be done by the caller. This check will be removed in future release. | |||
if not is_integer_dtype(indices.dtype): | |||
if indices.dtype.kind not in {"u", "i"}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be a problem incase of StructColumn
and DecimalColumn
's? Those types will lack .kind
attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have a default of "O"
(object type), so that would work here since we want to exclude those
In [1]: import cudf
In [2]: cudf.Decimal128Dtype(2)
Out[2]: Decimal128Dtype(precision=2, scale=0)
In [3]: cudf.Decimal128Dtype(2).kind
Out[3]: 'O'
In [4]: cudf.StructDtype({"a": "int64"}).kind
Out[4]: 'O'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, as long as that's covered we are good.
/merge |
Description
Checklist