Fix copy assignment and the comparison operator of rmm_host_allocator
#15677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PointKernel
reviewed
May 6, 2024
| */ | ||
| rmm_host_allocator& operator=(rmm_host_allocator const& other) | ||
| { | ||
| mr = other.mr; |
There was a problem hiding this comment.
I notice that the equality operator == also only checks mr but not stream. Seems it's intentional but not sure why. Worth double checking with @nvdbaranec
Could we set up a stream mode test for cpp/tests/utilities_tests/io_utilities_tests.cpp? In this way, we can avoid/uncover similar issues before delivery.
There was a problem hiding this comment.
Yeah, this should probably be checking the stream as well. If you had two of these objects using the same underlying allocator, but different streams you definitely could not consider them identical. Stream ordering violations could absolutely cause issues downstream.
There was a problem hiding this comment.
added stream comparison to the operator==
…bug-allocator-copy-wrong-stream
…vuule/cudf into bug-allocator-copy-wrong-stream
vuule
changed the title
rmm_host_allocatorrmm_host_allocator
vyasr
approved these changes
May 7, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copy assignment of
rmm_host_allocator, used inhostdevice_vector, is missing thestreammember assignment, leading to deallocation in the default stream in the assigned-to allocator.This PR fixes this error by switching to the auto-generated special functions.
Checklist