Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete XFAIL markers for query-planning #15662

Merged
merged 4 commits into from
May 9, 2024
Merged

Remove obsolete XFAIL markers for query-planning #15662

merged 4 commits into from
May 9, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented May 6, 2024

Description

Simple PR that removes/modifies several XFAIL markers for tests that should be passing with the latest version of dask. Note that the lt_version="2024.5.0" argument used in many places is conservative for most tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 6, 2024
@rjzamora rjzamora self-assigned this May 6, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 6, 2024
@rjzamora rjzamora marked this pull request as ready for review May 8, 2024 13:46
@rjzamora rjzamora requested a review from a team as a code owner May 8, 2024 13:46
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 8, 2024
charlesbluca
charlesbluca approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjzamora! One small question but generally LGTM

python/dask_cudf/dask_cudf/io/tests/test_parquet.py Show resolved Hide resolved
@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 8, 2024
@rjzamora
Copy link
Member Author

rjzamora commented May 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit a4cd1d8 into rapidsai:branch-24.06 May 9, 2024
70 checks passed
@rjzamora rjzamora deleted the relax-xfails branch May 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

Assignees

@rjzamora rjzamora

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjzamora @charlesbluca