Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libcudf developer guide for strings offsets column #15661

Merged
merged 11 commits into from
May 13, 2024
Merged

Update libcudf developer guide for strings offsets column #15661

merged 11 commits into from
May 13, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates the libcudf Developer Guide to better describe the strings offsets child column and include the offsetalator.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 6, 2024
@davidwendt davidwendt self-assigned this May 6, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 8, 2024
@davidwendt davidwendt marked this pull request as ready for review May 8, 2024 19:22
@davidwendt davidwendt requested a review from a team as a code owner May 8, 2024 19:22
PointKernel
PointKernel approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nit: similiar to STRING, we could highlight INT32/INT64 as INT32/INT64.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 13f028f into rapidsai:branch-24.06 May 13, 2024
70 checks passed
@davidwendt davidwendt deleted the fix-dev-guide-strings branch May 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @ttnghia @PointKernel