Fix -Werror=type-limits. #15635
Merged
Fix -Werror=type-limits. #15635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how to enforce |
bdice
added
improvement
mythrocks
approved these changes
May 2, 2024
| @@ -221,7 +221,7 @@ int32_t bz2_decompress_block(unbz_state_s* s) | |||
| if (getbits(s, 1)) return BZ_DATA_ERROR; // blockRandomized not supported (old bzip versions) | |||
|
|
|||
| s->origPtr = getbits(s, 24); | |||
| if (s->origPtr < 0 || s->origPtr > 10 + 100000 * s->blockSize100k) return BZ_DATA_ERROR; | |||
| if (s->origPtr > 10 + 100000 * s->blockSize100k) return BZ_DATA_ERROR; | |||
There was a problem hiding this comment.
👍 One wonders how we got here in the first place.
davidwendt
approved these changes
May 2, 2024
|
/merge |
Maybe I'm misunderstanding the problem, but could we just add this flag to our builds? We can add flags like this here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm compiling cuDF as a part of another application and ran into errors from
-Werror=type-limits. There are a few comparisons between unsigned types likevalue < 0, which is never true. This PR removes those impossible code paths.Checklist