Enable FutureWarnings/DeprecationWarnings as errors for dask_cudf #15634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
galipremsagar
approved these changes
May 1, 2024
bdice
approved these changes
May 1, 2024
|
Sorry - Just noticed that this PR may clash with #15593. Pretty sure my last commit will avoid the problem, but I will keep my eye on CI and follow up if I missed anything. [EDIT: Definitely looks like I'll need to do some dask-cudf cleanup to get this passing - Sorry about that.] |
3 tasks
wence-
approved these changes
May 3, 2024
Comment on lines
87
to
88
| f = tmp_path / "data.json" | ||
| f.touch() |
There was a problem hiding this comment.
question: Why do we need to touch the file first?
There was a problem hiding this comment.
Ah turns out we didn't need to touch the file. Removed
| @@ -543,7 +543,7 @@ def test_struct_explode(data): | |||
|
|
|||
|
|
|||
| def test_tz_localize(): | |||
| data = Series(date_range("2000-04-01", "2000-04-03", freq="H")) | |||
| data = Series(date_range("2000-04-01", "2000-04-03", freq="h")) | |||
There was a problem hiding this comment.
Not "always wrong" I think these aliases are just deprecated in pandas 2.x
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 4, 2024
Part of rapidsai/build-planning#26 Builds on #15634 Authors: - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #15642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of rapidsai/build-planning#26
Checklist