Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid accessing attributes via _column if not needed #15624

Merged
merged 3 commits into from
May 7, 2024
Merged

Avoid accessing attributes via _column if not needed #15624

merged 3 commits into from
May 7, 2024

Conversation

mroeschke
Copy link
Contributor

Description

xref #15494

If the attributes are exposed on the top level object e.g. Index.dtype it should be sufficient to just access the attributes there instead of reaching for the underlying object

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 30, 2024
@mroeschke mroeschke requested a review from a team as a code owner April 30, 2024 23:35
@mroeschke mroeschke requested review from bdice and isVoid April 30, 2024 23:35
vyasr
vyasr approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely agree with the premise! Also, the function call makes it significantly more explicit that a data conversion (read: materialization) could be happening.

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5154661 into rapidsai:branch-24.06 May 7, 2024
70 checks passed
@mroeschke mroeschke deleted the ref/less/_column branch May 7, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr