Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use experimental make_strings_children in nvtext APIs #15595

Merged
merged 5 commits into from
May 1, 2024
Merged

Use experimental make_strings_children in nvtext APIs #15595

merged 5 commits into from
May 1, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates nvtext replace, ngram, normalize, and detokenize functions to replace the existing calls to make_strings_children with the new experimental make_strings_children which supports building large strings.

Reference #15579

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 24, 2024
@davidwendt davidwendt self-assigned this Apr 24, 2024
@davidwendt davidwendt mentioned this pull request Apr 24, 2024
Open
33 tasks
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 25, 2024
@davidwendt davidwendt marked this pull request as ready for review April 25, 2024 13:10
@davidwendt davidwendt requested a review from a team as a code owner April 25, 2024 13:10
bdice
bdice approved these changes Apr 30, 2024
View reviewed changes
cpp/src/text/detokenize.cu Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fe4b92c into rapidsai:branch-24.06 May 1, 2024
70 checks passed
@davidwendt davidwendt deleted the ls-nvtext branch May 1, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vuule vuule vuule approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @vuule