Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove index name overrides in dask-cudf pyarrow table dispatch #15514

Merged
merged 17 commits into from
Apr 22, 2024
Merged

Remove index name overrides in dask-cudf pyarrow table dispatch #15514

merged 17 commits into from
Apr 22, 2024

Conversation

charlesbluca
Copy link
Member

Description

Looks like these overrides should be safe to remove now that #14159 is closed out.

This should unblock the GPU CI failures we're seeing on Dask with 24.06 in dask/dask#11045.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@charlesbluca charlesbluca requested a review from a team as a code owner April 11, 2024 18:10
@charlesbluca charlesbluca added bug Something isn't working 3 - Ready for Review Ready for review by team labels Apr 11, 2024
@charlesbluca charlesbluca self-assigned this Apr 11, 2024
@charlesbluca charlesbluca added Python Affects Python cuDF API. dask Dask issue non-breaking Non-breaking change labels Apr 11, 2024
rjzamora
rjzamora approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesbluca !

@charlesbluca
Copy link
Member Author

/merge

@vyasr
Copy link
Contributor

vyasr commented Apr 16, 2024

@charlesbluca looks like there are real failures here, so perhaps this change isn't safe after all?

@charlesbluca charlesbluca requested a review from a team as a code owner April 17, 2024 14:43
@rjzamora rjzamora mentioned this pull request Apr 18, 2024
Merged
@rjzamora
Merge branch 'charlesbluca/remove-arrow-dispatch-overrides' of github…
a75cb9a 
….com:charlesbluca/cudf into charlesbluca/remove-arrow-dispatch-overrides
@rjzamora
Copy link
Member

@wence- - any concerns with the recent to_arrow changes here?

Note: I basically set a breakpoint inside of pyarrow.pandas_compat.construct_metadata and did my best to align our inputs with what pyarrow.Table.from_pandas was passing in for the same kind of data.

@rapids-bot rapids-bot bot merged commit 475f5e5 into rapidsai:branch-24.06 Apr 22, 2024
69 checks passed
rjzamora
rjzamora reviewed Apr 22, 2024
View reviewed changes
python/cudf/cudf/core/dataframe.py

out = super(DataFrame, data).to_arrow()
# import pdb; pdb.set_trace()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops- Forgot this PR was already marked with a /merge comment.
Forgot to remove this comment - Hopefully nothing else...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@rjzamora rjzamora rjzamora approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@charlesbluca charlesbluca

Labels
3 - Ready for Review Ready for review by team bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@charlesbluca @vyasr @rjzamora @wence- @galipremsagar