Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test static builds in CI and fix nanoarrow configure #15437

Merged
merged 17 commits into from
Apr 2, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 2, 2024

Description

Resolves #15275
Resolves #15434

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this Apr 2, 2024
@github-actions github-actions bot added the ci label Apr 2, 2024
@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change and removed ci labels Apr 2, 2024
@vyasr vyasr force-pushed the fix/nanoarrow_static_build branch from 5009a99 to a554f1f Compare April 2, 2024 16:39
@github-actions github-actions bot added the ci label Apr 2, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Apr 2, 2024
@vyasr vyasr marked this pull request as ready for review April 2, 2024 17:31
@vyasr vyasr requested review from a team as code owners April 2, 2024 17:31
.github/workflows/pr.yaml Show resolved Hide resolved
ci/configure_cpp_static.sh Outdated Show resolved Hide resolved
ci/configure_cpp_static.sh Show resolved Hide resolved
@vyasr vyasr requested a review from bdice April 2, 2024 21:17
@ttnghia
Copy link
Contributor

ttnghia commented Apr 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2584fd9 into rapidsai:branch-24.06 Apr 2, 2024
74 checks passed
@vyasr vyasr deleted the fix/nanoarrow_static_build branch April 2, 2024 23:44
@jlowe
Copy link
Member

jlowe commented Apr 3, 2024

This fix allows our spark-rapids-jni builds to progress past the libcudf configure and successfully build and install libcudf. However once we try to use the installed libcudf, it fails with another nanoarrow issue. See #15453.

rapids-bot bot pushed a commit that referenced this pull request Apr 16, 2024
The new `configure_cpp_static.sh` script added in #15437 is calling `rapids-configure-conda-channels`. However, it is doing so on a `ci-wheel` image, which fails. This is causing CI issues and needs to be removed.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #15539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Archived in project
6 participants