Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update udf_cpp to use rapids_cpm_cccl. #15331

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Update udf_cpp to use rapids_cpm_cccl. #15331

merged 1 commit into from
Mar 25, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 18, 2024

Description

This PR updates the udf_cpp target to use rapids_cpm_cccl. The previous rapids_cpm_libcudacxx has been deprecated.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice changed the base branch from branch-24.04 to branch-24.06 March 18, 2024 19:26
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Mar 18, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 18, 2024
@bdice bdice self-assigned this Mar 18, 2024
@bdice bdice changed the title Update udf_cpp to use rapids_cpm_cccl." Update udf_cpp to use rapids_cpm_cccl. Mar 18, 2024
@bdice
Copy link
Contributor Author

bdice commented Mar 18, 2024

@robertmaynard Do you have thoughts on whether this should target 24.04 or 24.06, due to the deprecation?

@bdice bdice marked this pull request as ready for review March 18, 2024 22:11
@bdice bdice requested a review from a team as a code owner March 18, 2024 22:11
@robertmaynard
Copy link
Contributor

@robertmaynard Do you have thoughts on whether this should target 24.04 or 24.06, due to the deprecation?

Go with 24.06, we will just suffer with warning when building 24.04

@bdice
Copy link
Contributor Author

bdice commented Mar 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 933e32a into rapidsai:branch-24.06 Mar 25, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @robertmaynard @shwina