Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GroupBy.get_group and GroupBy.indices #15143

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Fix GroupBy.get_group and GroupBy.indices #15143

merged 11 commits into from
Mar 5, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Feb 26, 2024

Description

These are supposed to index based on row indices, not row labels.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
Fix GroupBy.get_group and GroupBy.indices
4f2fa9f 
These are supposed to index based on row indices, not row labels.

- Closes rapidsai#14955
@wence-
Add test
d9d077f
@wence- wence- requested a review from a team as a code owner February 26, 2024 19:03
@wence- wence- mentioned this pull request Feb 26, 2024
Merged
2 tasks
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 26, 2024
@wence- wence- added bug Something isn't working non-breaking Non-breaking change labels Feb 27, 2024
@wence-
Copy link
Contributor Author

wence- commented Feb 27, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Feb 28, 2024

/merge

@vyasr
Copy link
Contributor

vyasr commented Feb 29, 2024

/merge

@rjzamora
Copy link
Member

/merge

rjzamora added a commit to rjzamora/cudf that referenced this pull request Feb 29, 2024
@rjzamora
remove more code - sits on top of rapidsai#15143
be88773
@wence-
Copy link
Contributor Author

wence- commented Mar 1, 2024

conda-java-tests fail is due to NVIDIA/spark-rapids-jni#1820

wheel tests on 11.8 fail is worrying: 2024-03-01T11:38:56.8171936Z E MemoryError: std::bad_alloc: CUDA error at: /__w/rmm/rmm/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered

@rjzamora
Copy link
Member

rjzamora commented Mar 1, 2024

wheel tests on 11.8 fail is worrying

Just a note that #14805 is sitting on top of these changes, and the only failure over there is conda-java-tests

@wence-
Copy link
Contributor Author

wence- commented Mar 1, 2024

I think the dask-cudf problems are an actual bug: #15204

@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 1, 2024
@vyasr
Copy link
Contributor

vyasr commented Mar 1, 2024

Temporarily blocking in case the dask_cudf issue is in fact caused by this PR.

@vyasr
Copy link
Contributor

vyasr commented Mar 4, 2024

See #15216 for the issue, we can continue with this PR.

@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 4, 2024
@wence-
Copy link
Contributor Author

wence- commented Mar 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit d4368e9 into rapidsai:branch-24.04 Mar 5, 2024
73 checks passed
@wence- wence- deleted the wence/fix/14955 branch March 5, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Groupby.get_group returns wrong result for repeated index
4 participants
@wence- @vyasr @rjzamora @bdice