Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align date_range defaults with pandas, support tz #15139

Merged
merged 15 commits into from
Apr 3, 2024
Merged

Align date_range defaults with pandas, support tz #15139

merged 15 commits into from
Apr 3, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Precursor to #15116

  • Aligns date_range signature with pandas, technically an API breakage with closed changing defaults even though it still isn't supported
  • Copies pandas behavior of allowing date_range with just two of start/end/periods
  • Supports tz arg now

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 24, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 24, 2024 02:12
@wence-
Copy link
Contributor

wence- commented Feb 27, 2024

@mroeschke does this also fix #12133 ?

@mroeschke
Copy link
Contributor Author

@mroeschke does this also fix #12133 ?

Not this PR, no. I am planning on tackling that issue (which might be the same as #15116) in a follow up to this

@mroeschke mroeschke changed the base branch from branch-24.04 to branch-24.06 March 18, 2024 22:06
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5192b60 into rapidsai:branch-24.06 Apr 3, 2024
73 checks passed
@mroeschke mroeschke deleted the enh/date_range_tz branch April 3, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @wence- @galipremsagar