Eliminate duplicate allocation of nested string columns #15061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
nvdbaranec
reviewed
Feb 16, 2024
…bug-read_parquet-nested-str-alloc
…m/vuule/cudf into bug-read_parquet-nested-str-alloc
bdice
approved these changes
Feb 26, 2024
ttnghia
reviewed
Feb 26, 2024
ttnghia
approved these changes
Feb 26, 2024
bdice
reviewed
Feb 26, 2024
Co-authored-by: Nghia Truong <7416935+ttnghia@users.noreply.github.com>
vuule
commented
Feb 26, 2024
cpp/src/io/parquet/reader_impl.cpp
Outdated
| @@ -281,7 +282,7 @@ void reader::impl::decode_page_data(size_t skip_rows, size_t num_rows) | |||
| out_buf.user_data |= PARQUET_COLUMN_BUFFER_FLAG_LIST_TERMINATED; | |||
| } else if (out_buf.type.id() == type_id::STRING) { | |||
| // need to cap off the string offsets column | |||
| size_type const sz = static_cast<size_type>(col_sizes[idx]); | |||
| size_type const sz = static_cast<size_type>(col_string_sizes[idx]); | |||
There was a problem hiding this comment.
Using size_type here for now. When we get to supporting larger string columns in the reader, we'll probably use an offsetalator (or something similar) here.
bdice
approved these changes
Feb 26, 2024
harrism
requested changes
Feb 26, 2024
…m/vuule/cudf into bug-read_parquet-nested-str-alloc
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #14965
Checklist