Remove supports_streams from cuDF custom memory resources. #14857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
feature request
github-actions
bot
added
libcudf
ttnghia
approved these changes
Jan 24, 2024
bdice
approved these changes
Jan 24, 2024
PointKernel
approved these changes
Jan 24, 2024
|
This depends on rapidsai/rmm#1437 , so if any of the approvers on this PR would like to approve that PR, that would be a big help. |
miscco
approved these changes
Jan 26, 2024
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Feb 1, 2024
Deprecates now unused `device_memory_resource::supports_streams()`. Will be removed in next release (24.06). Merge after: * rapidsai/raft#2121 * rapidsai/cudf#14857 Closes #1433 Authors: - Mark Harris (https://github.com/harrism) Approvers: - Michael Schellenberger Costa (https://github.com/miscco) - Bradley Dice (https://github.com/bdice) URL: #1452
mythrocks
added a commit
to mythrocks/spark-rapids-jni
that referenced
this pull request
Mar 7, 2024
Fixes NVIDIA#1814. This change removes the override of `spark_resource_adaptor::supports_stream()`, in light of rapidsai/rmm#1389, which deprecated the method. Similar to rapidsai/cudf#14857, this change removes the deprecated override. Signed-off-by: MithunR <mythrocks@gmail.com>
mythrocks
added a commit
to NVIDIA/spark-rapids-jni
that referenced
this pull request
Mar 10, 2024
Fixes #1814. This change removes the override of `spark_resource_adaptor::supports_stream()`, in light of rapidsai/rmm#1389, which deprecated the method. Similar to rapidsai/cudf#14857, this change removes the deprecated override. Signed-off-by: MithunR <mythrocks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of rapidsai/rmm#1389. This removes now-optional and soon-to-be deprecated
supports_streams()from cuDF's customdevice_memory_resourceimplementations.Depends on rapidsai/rmm#1437
Checklist