Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cudf::char_utf8 definition from detail to public header #14779

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Moves the cudf::char_utf8 definition from the cudf/strings/detail/utf8.hpp to cudf/types.hpp since it is declared in the public namespace and used in public functions.

Reference:

# TODO: This type is currently defined in a detail header but it's in
# the public namespace. However, it's used in the detail header, so it
# needs to be put into a public header that can be shared.
"char_utf8",

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 18, 2024
@davidwendt davidwendt self-assigned this Jan 18, 2024
@davidwendt davidwendt requested a review from a team as a code owner January 18, 2024 15:59
@davidwendt davidwendt requested review from ttnghia, PointKernel and vyasr and removed request for ttnghia January 18, 2024 15:59
@ttnghia
Copy link
Contributor

ttnghia commented Jan 18, 2024

@davidwendt Do we need to update cudf/docs/cudf/source/conf.py accordingly?

@davidwendt
Copy link
Contributor Author

@davidwendt Do we need to update cudf/docs/cudf/source/conf.py accordingly?

That is a good question. I made @vyasr a reviewer. I think that I can just remove the comment.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this David! Yes, you can remove the comment as well as the line below it that actually says "char_utf8".

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 446da75 into rapidsai:branch-24.02 Jan 19, 2024
66 of 67 checks passed
@davidwendt davidwendt deleted the move-char-utf8-to-public branch January 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants