Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use column_empty over as_column([]) #14632

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Use column_empty over as_column([]) #14632

merged 1 commit into from
Dec 14, 2023

Conversation

mroeschke
Copy link
Contributor

Description

Remove unnecessary "inference" on [] in as_column. Additionally fixed a bug in arange and istimestamp to return an int and bool type respectively for empty inputs for consistency with non-empty inputs

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Dec 14, 2023
@mroeschke mroeschke requested a review from a team as a code owner December 14, 2023 20:01
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 39386c2 into rapidsai:branch-24.02 Dec 14, 2023
67 checks passed
@mroeschke mroeschke deleted the ref/column_empty branch December 14, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @bdice