Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data corruption when skipping rows #14557

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix data corruption when skipping rows #14557

merged 1 commit into from
Dec 5, 2023

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Dec 4, 2023 •
edited
Loading

Description

Fixes an issue detected in Spark where string data was being corrupted due to an incorrect page size calculation.

Closes #14560

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@etseidl etseidl requested a review from a team as a code owner December 4, 2023 16:31
@etseidl etseidl requested review from PointKernel and divyegala and removed request for a team December 4, 2023 16:31
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 4, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue non-breaking Non-breaking change labels Dec 4, 2023
@ttnghia ttnghia added the Spark Functionality that helps Spark RAPIDS label Dec 4, 2023
@ttnghia
Copy link
Contributor

ttnghia commented Dec 4, 2023

/ok to test

@abellina abellina mentioned this pull request Dec 4, 2023
Closed
abellina
abellina approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etseidl @nvdbaranec this PR fixes the corruption for me. Thanks!!

@PointKernel
Copy link
Member

@etseidl can you please rebase the branch against 24.02 instead of 23.12?

@etseidl
Copy link
Contributor Author

etseidl commented Dec 4, 2023

can you please rebase the branch against 24.02 instead of 23.12?

I'm sorry. I thought this was wanted before 23.12 went out. @abellina ?

@GregoryKimball
Copy link
Contributor

Yes, let's please leave this on 23.12 for now

@ttnghia
Copy link
Contributor

ttnghia commented Dec 4, 2023

@GregoryKimball should this still target 22.12?

@vuule vuule self-assigned this Dec 4, 2023
@vuule vuule self-requested a review December 4, 2023 22:08
@raydouglass raydouglass merged commit 31aedf2 into rapidsai:branch-23.12 Dec 5, 2023
63 of 65 checks passed
@etseidl etseidl deleted the skip_rows_hotfix branch December 5, 2023 17:14
@sameerz sameerz mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellina abellina abellina approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@vuule vuule vuule approved these changes

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
3 - Ready for Review Ready for review by team bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@etseidl @ttnghia @PointKernel @GregoryKimball @abellina @hyperbolic2346 @vuule @raydouglass @davidwendt