-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix host buffer access from device function in the Parquet reader #14328
Fix host buffer access from device function in the Parquet reader #14328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any test for the related function? If yes, how this didn't crash the test?
The use of pinned memory was hiding the issue. When using pageable memory in |
Then can we have a test with both pinned memory/pageable memory? Such as through macro definition or toggling the corresponding env variable? |
I've started working on the test and realized some problems. The env var is read only once and cached. We can't enable pageable memory use for only one test. |
/merge |
Merged to enable spark experiments; we can add tests in a separate PR. |
Description
Closes #14311
The host access becomes an issue when pageable memory is used for host side of
hostdevice_vector
.This PR fixes the device lambda to use the device pointer instead.
Checklist