Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream parameter to List Sort and Filter APIs #14272

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Add stream parameter to List Sort and Filter APIs #14272

merged 3 commits into from
Oct 16, 2023

Conversation

SurajAralihalli
Copy link
Contributor

@SurajAralihalli SurajAralihalli commented Oct 11, 2023 •
edited
Loading

This PR introduces the stream parameter to the List Sorting and Filtering APIs.

Sorting and Filtering (extract.hpp, filling.hpp, gather.hpp, reverse.hpp, sorting.hpp, stream_compaction.hpp)

extract_list_element - index
extract_list_element - indices
segmented_gather
sequences - without steps
sequences - with steps
reverse
sort_lists
stable_sort_lists
apply_boolean_mask
distinct

Reference 13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@SurajAralihalli
Updates List based Sorting and Filtering APIs
9b1fbeb 
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@SurajAralihalli
fix compile errors
b1d83f4 
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 11, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 11, 2023
@davidwendt davidwendt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 11, 2023
@SurajAralihalli
adds test cases
6fdfb9b 
Signed-off-by: Suraj Aralihalli <suraj.ara16@gmail.com>
@SurajAralihalli SurajAralihalli marked this pull request as ready for review October 12, 2023 06:22
@SurajAralihalli SurajAralihalli requested a review from a team as a code owner October 12, 2023 06:22
@davidwendt
Copy link
Contributor

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Oct 16, 2023

/merge

@rapids-bot rapids-bot bot merged commit c47546e into rapidsai:branch-23.12 Oct 16, 2023
60 checks passed
@davidwendt davidwendt mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@ttnghia ttnghia ttnghia approved these changes

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SurajAralihalli @davidwendt @vyasr @ttnghia